feat: (mvux) Add new UpdateItemasync Extension Method #2642
Conversation
Co-authored-by: David <[email protected]>
ajpinedam
force-pushed
the
feat/mvux.updateitemasync
branch
from
2983601 to
4fe5eca
Compare
| /// <param name="state">The list state onto which the item should be added.</param> | ||
| /// <param name="oldItem">The old value of the item.</param> | ||
| /// <param name="updater">How to update items.</param> | ||
| /// <param name="ct">A token to abort the async add operation.</param> |
There was a problem hiding this comment.
nit: the ct param comment mentions it is for aborting the add operation. Probably just a copy-paste thing but this isn't necessarily an add operation. We could be more general and just mention it as an async operation
| /// <param name="state">The list state onto which the item should be added.</param> | ||
| /// <param name="oldItem">The old value of the item.</param> | ||
| /// <param name="updater">How to update items.</param> | ||
| /// <param name="ct">A token to abort the async add operation.</param> |
There was a problem hiding this comment.
nit: the ct param comment mentions it is for aborting the add operation. Probably just a copy-paste thing but this isn't necessarily an add operation. We could be more general and just mention it as an async operation
| /// <param name="state">The list state onto which the item should be added.</param> | ||
| /// <param name="oldItem">The old value of the item.</param> | ||
| /// <param name="newItem">The new value for the item.</param> | ||
| /// <param name="ct">A token to abort the async add operation.</param> |
There was a problem hiding this comment.
nit: the ct param comment mentions it is for aborting the add operation. Probably just a copy-paste thing but this isn't necessarily an add operation. We could be more general and just mention it as an async operation
| /// <param name="state">The list state onto which the item should be added.</param> | ||
| /// <param name="oldItem">The old value of the item.</param> | ||
| /// <param name="newItem">The new value for the item.</param> | ||
| /// <param name="ct">A token to abort the async add operation.</param> |
There was a problem hiding this comment.
nit: the ct param comment mentions it is for aborting the add operation. Probably just a copy-paste thing but this isn't necessarily an add operation. We could be more general and just mention it as an async operation
Co-authored-by: Steve Bilogan <[email protected]>
GitHub Issue (If applicable): closes #2582
PR Type
What kind of change does this PR introduce?
What is the current behavior?
To update an item, we need to do something like ListState.UpdateAllAsync(t => t.KeyEquals(newT), newT);
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):